jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r550905278
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/DeleteTopicsRequest.java
##########
@@ -39,8 +45,25 @@ public Builder(DeleteTopicsRequestData data) {
@Override
public DeleteTopicsRequest build(short version) {
+ if (version >= 6 && data.topicNames().size() != 0) {
+ data.setTopics(groupByTopic(data.topicNames()));
+ } else if (version >= 6) {
+ for (DeleteTopicState topic : data.topics()) {
+ if (topic.name().equals("")) {
Review comment:
Good point. I think I was assuming the default is the empty string, but
someone could set the data field to null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
