[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

[GitBox]

jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r546406433



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -1896,6 +1896,11 @@ class KafkaApis(val requestChannel: RequestChannel,
               .setTopicConfigErrorCode(Errors.NONE.code)
           }
         }
+        val topicIds = 
zkClient.getTopicIdsForTopics(results.asScala.map(result => 
result.name()).toSet)

Review comment:
       Currently the KIP-516 work relies on ZK for storing the topic IDs. I 
think we will need to make some more changes when KIP-500 fully removes ZK




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org