showuon commented on a change in pull request #9789: URL: https://github.com/apache/kafka/pull/9789#discussion_r549558749
########## File path: core/src/main/scala/kafka/network/SocketServer.scala ########## @@ -988,60 +990,79 @@ private[kafka] class Processor(val id: Int, } } + protected def isControlRequest(header: RequestHeader): Boolean = { Review comment: could we use `private` here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org