showuon commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-751936350
@wenbingshen , thanks for the PR. Some comments left, but most importantly, we don't know which JIRA ticket you're fixing. Please check the [contributing code change](https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes) page. Thank you. > The PR title should usually be of the form KAFKA-xxxx: Title, where KAFKA-xxxx is the relevant JIRA id and Title may be the JIRA's title or a more specific title describing the PR itself. For trivial cases where a JIRA is not required (see JIRA section for more details) MINOR: or HOTFIX: can be used as the PR title prefix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org