ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529932449
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java
##########
@@ -198,9 +200,16 @@ public void
testRegexRecordsAreProcessedAfterReassignment() throws Exception {
final StreamsBuilder builder = new StreamsBuilder();
final KStream<String, String> pattern1Stream =
builder.stream(Pattern.compile("TEST-TOPIC-\\d"));
- pattern1Stream.to(outputTopic, Produced.with(Serdes.String(),
Serdes.String()));
+ final KStream<String, String> otherStream =
builder.stream(Pattern.compile("not-a-match"));
+
+ pattern1Stream
+ .selectKey((k, v) -> k)
+ .groupByKey()
+ .aggregate(() -> "", (k, v, a) -> v)
+ .toStream().to(outputTopic, Produced.with(Serdes.String(),
Serdes.String()));
Review comment:
There are two ways to have more than one source node: either reading
from a different input topic/pattern, or via a repartition. I agree that we
should test both of these cases, but I'd prefer to do so in a single
integration test rather than in two separate integration tests, to avoid making
the test suite even longer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
