ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529109355
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java
##########
@@ -198,9 +200,16 @@ public void
testRegexRecordsAreProcessedAfterReassignment() throws Exception {
final StreamsBuilder builder = new StreamsBuilder();
final KStream<String, String> pattern1Stream =
builder.stream(Pattern.compile("TEST-TOPIC-\\d"));
- pattern1Stream.to(outputTopic, Produced.with(Serdes.String(),
Serdes.String()));
+ final KStream<String, String> otherStream =
builder.stream(Pattern.compile("not-a-match"));
Review comment:
We didn't catch the bug in this test for two reasons: it has only one
subtopology, and it didn't wait for Streams to get to RUNNING before it created
the new topic. So we weren't even covering the "update source topics" code path
since all topics existed by the first assignment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
