chia7712 commented on a change in pull request #9547:
URL: https://github.com/apache/kafka/pull/9547#discussion_r517212012


##########
File path: 
clients/src/main/resources/common/message/OffsetForLeaderEpochRequest.json
##########
@@ -32,13 +32,13 @@
     { "name": "Topics", "type": "[]OffsetForLeaderTopic", "versions": "0+",
       "about": "Each topic to get offsets for.", "fields": [
       { "name": "Name", "type": "string", "versions": "0+", "entityType": 
"topicName",

Review comment:
       Previous "name" is ```topic``` 
(https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/protocol/CommonFields.java#L25)
 and the "name" in auto-generated protocol is ```name```. Does it break the 
compatibility? For example, a cluster mixed by auto-generated protocol and 
stale protocol. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to