hachikuji commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r516933962
##########
File path:
core/src/test/scala/unit/kafka/admin/PreferredReplicaLeaderElectionCommandTest.scala
##########
@@ -54,8 +55,15 @@ class PreferredReplicaLeaderElectionCommandTest extends
ZooKeeperTestHarness wit
private def createTestTopicAndCluster(topicPartition: Map[TopicPartition,
List[Int]],
authorizer: Option[String] = None):
Unit = {
+ val brokerConfigs = (0 until 3).map { node =>
Review comment:
Do we need this change anymore?
##########
File path: core/src/test/scala/unit/kafka/api/ApiVersionTest.scala
##########
@@ -104,7 +123,7 @@ class ApiVersionTest {
apiVersion.id
})
- val uniqueIds: Set[Int] = allIds.toSet
+ val uniqueIds: Predef.Set[Int] = allIds.toSet
Review comment:
nit: is this change needed?
##########
File path:
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala
##########
@@ -360,6 +360,8 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationTest with SaslSetu
// Test that we cannot create or delete ACLs when ALTER is denied.
authorizationAdmin.addClusterAcl(DENY, ALTER)
+ // CLUSTER_ACTION shall also be forbid since the request goes to privilege
listener
+ authorizationAdmin.addClusterAcl(DENY, CLUSTER_ACTION)
Review comment:
Is this change needed? I am not sure I follow the comment about the
privileged listener. That shouldn't affect ACLs I think.
##########
File path:
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationWithForwardingIntegrationTest.scala
##########
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package kafka.server
+
+import java.util.Properties
+
+import org.junit.Test
+
+/**
+ * Integration test suite for forwarding mechanism applied on AlterConfigs.
+ * This class basically reused everything from {@link
DynamicBrokerReconfigurationTest}
+ * with the KIP-500 mode enabled for sasl listener alter test.
+ */
+class DynamicBrokerReconfigurationWithForwardingIntegrationTest extends
DynamicBrokerReconfigurationTest {
Review comment:
This inherits all tests from `DynamicBrokerReconfigurationTest`, which
doesn't look to be intended. Can we just remove it? We can add it back once we
get to testing the ssl path changes. For now I think the simple integration
test for CreateTopics is good enough.
(By the way, it's curious that `testTrustStoreAlter` still passes even after
we have removed the path update logic.)
##########
File path: core/src/test/scala/unit/kafka/server/BaseRequestTest.scala
##########
@@ -45,6 +45,7 @@ abstract class BaseRequestTest extends IntegrationTestHarness
{
override def modifyConfigs(props: Seq[Properties]): Unit = {
props.foreach { p =>
p.put(KafkaConfig.ControlledShutdownEnableProp, "false")
+ p.put(KafkaConfig.EnableMetadataQuorumProp, "true")
Review comment:
I don't think we want to make this the default until we are ready to
enable it. I would suggest we create a new `ForwardRequestTest` which extends
`BaseRequestTest`. Then we can move the test case from
`CreateTopicsRequestTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
