[GitHub] [kafka] abbccdda commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

[GitBox]

abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r513757978



##########
File path: 
clients/src/test/java/org/apache/kafka/common/protocol/ApiKeysTest.java
##########
@@ -59,7 +59,8 @@ public void testResponseThrottleTime() {
         for (ApiKeys apiKey: ApiKeys.values()) {
             Schema responseSchema = 
apiKey.responseSchema(apiKey.latestVersion());
             BoundField throttleTimeField = 
responseSchema.get(CommonFields.THROTTLE_TIME_MS.name);
-            if (apiKey.clusterAction || authenticationKeys.contains(apiKey))
+            // Envelope could be throttled, even though it requires cluster 
action.
+            if (apiKey != ApiKeys.ENVELOPE && (apiKey.clusterAction || 
authenticationKeys.contains(apiKey)))

Review comment:
       Sounds good, will remove the throttle time field from the Envelope
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org