[
https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169062#comment-17169062
]
John Thomas commented on KAFKA-10316:
-------------------------------------
[~mjsax] The vote has been open for >72 hours, and the KIP got binding+1 (John
Roesler) , non-binding+1 (Navinder Brar, Jorge Esteban, Bruno Cadonna) and no
-1 votes.
Need little help figuring this out , Will the approval be of type 1 or 2 ?
# The [KIP process point
4|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-Process]
says : The criteria for acceptance is [lazy
majority|https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals].
# At the same time in the
[Bylaws|https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Approvals]
for a "code change action" approval "one +1 from a committer who has not
authored the patch followed by a Lazy approval (not counting the vote of the
contributor), moving to lazy majority if a -1 is received" .
> Consider renaming getter method for Interactive Queries
> -------------------------------------------------------
>
> Key: KAFKA-10316
> URL: https://issues.apache.org/jira/browse/KAFKA-10316
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: John Thomas
> Priority: Minor
> Labels: beginner, need-kip, newbie
>
> In the 2.5 release, we introduce new classes for Interactive Queries via
> KIP-535 (cf https://issues.apache.org/jira/browse/KAFKA-6144). The KIP did
> not specify the names for getter methods of `KeyQueryMetadata` explicitly and
> they were added in the PR as `getActiveHost()`, `getStandbyHosts()`, and
> `getPartition()`.
> However, in Kafka it is custom to not use the `get` prefix for getters and
> thus the methods should have been added as `activeHost()`, `standbyHosts()`,
> and `partition()`, respectively.
> We should consider renaming the methods accordingly, by deprecating the
> existing ones and adding the new ones in parallel.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
