[
https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166706#comment-17166706
]
Matthias J. Sax commented on KAFKA-10316:
-----------------------------------------
Thanks. – I glanced over the KIP quickly and it look good. Please also add to
the main KIP table as this table should list all KIPs.
As this KIP is rather straightforward, I agree that we can skip the discuss
thread and you can call for a vote right away.
> Consider renaming getter method for Interactive Queries
> -------------------------------------------------------
>
> Key: KAFKA-10316
> URL: https://issues.apache.org/jira/browse/KAFKA-10316
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: John Thomas
> Priority: Minor
> Labels: beginner, need-kip, newbie
>
> In the 2.5 release, we introduce new classes for Interactive Queries via
> KIP-535 (cf https://issues.apache.org/jira/browse/KAFKA-6144). The KIP did
> not specify the names for getter methods of `KeyQueryMetadata` explicitly and
> they were added in the PR as `getActiveHost()`, `getStandbyHosts()`, and
> `getPartition()`.
> However, in Kafka it is custom to not use the `get` prefix for getters and
> thus the methods should have been added as `activeHost()`, `standbyHosts()`,
> and `partition()`, respectively.
> We should consider renaming the methods accordingly, by deprecating the
> existing ones and adding the new ones in parallel.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
