chia7712 commented on pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#issuecomment-654594491


   @vvcephei thanks for all reviews.
   
   > processor.node.account.ssh(cmd, allow_fail=False)
   
   Did you mean that we can reuse one of processor to call 
```kafka-streams-application-reset.sh```? If so, the reason I did not apply 
that approach is that the stdout/log is mixed with existent processor output. 
It seems to me the output gets a bit chaos.
   
   > minor note: this pattern only verifies that the resetter finishes running, 
not that it runs successfully.
   
   there is a wait for expected message. ```
               monitor.wait_until(self.expectedMessage, timeout_sec=60, 
err_msg="Never saw message indicating StreamsTest finished startup on " + 
str(node.account))```. It can't pass if resetter fails to run.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to