ableegoldman commented on a change in pull request #8962:
URL: https://github.com/apache/kafka/pull/8962#discussion_r448715259
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##########
@@ -578,4 +580,14 @@ private StateStoreMetadata findStore(final TopicPartition
changelogPartition) {
return found.isEmpty() ? null : found.get(0);
}
+
+ // Pass in a sentinel value to checkpoint when the changelog offset is not
yet initialized/known
+ private long checkpointableOffsetFromChangelogOffset(final Long offset) {
+ return offset != null ? offset : OFFSET_UNKNOWN;
Review comment:
This is a little awkward, and it might be cleaner to just replace the
use of `null` with this `OFFSET_UNKNOWN` sentinel throughout the
ProcessorStateManager/StoreChangelogReader -- but, I wanted to keep the changes
as short and simple as possible for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
