showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-648846927
Hi @ableegoldman , thanks for the good suggestion! I've updated in this commit: https://github.com/apache/kafka/pull/8712/commits/f378c34d10c57d796412ac946f867e5787f93af0. What I did in this commit is: 1. rewrite the test by `EasyMock`, to make the tests better, and because of this test rewrite, I found a bug that I missed before, which is that when we retried the `describeTopics`, we should also add the `tempUnknownTopics` into the list since they also needed to be retried. Thanks for the suggestion! 2. remove unneeded hack in MockAdminClient 3. rename the variable name `leaderNotAvailableTopics` to `tempUnknownTopics` 4. use `isEmpty()` to be consistent Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
