[GitHub] [kafka] mjsax commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

[GitBox]

mjsax commented on a change in pull request #8876:
URL: https://github.com/apache/kafka/pull/8876#discussion_r441920504



##########
File path: 
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -478,6 +479,7 @@ private void setupTask(final StreamsConfig streamsConfig,
                     mockWallClockTime,
                     streamsConfig,
                     logContext,
+                    
createAdminClient(processorTopology.storeToChangelogTopic()),

Review comment:
       This is the only thing I am wondering about. Why not just pass `null`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org