mjsax commented on a change in pull request #8876:
URL: https://github.com/apache/kafka/pull/8876#discussion_r441252009
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##########
@@ -564,8 +576,15 @@ private void restoreChangelog(final ChangelogMetadata
changelogMetadata) {
return Collections.emptyMap();
try {
- return restoreConsumer.endOffsets(partitions);
- } catch (final TimeoutException e) {
+ if (adminClient != null) {
Review comment:
I just saw that we kinda need to pass `null` as `AdminClient` in TDD --
however, `StoreChangelogReader#restore()` is never called by TTD, and thus I
still think we should remove the `null` check and fail hard with a NPE as it
would indicate a bug if `adminClient` is `null` in a regular deployment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
