ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r436178123
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -360,7 +360,7 @@ class LogManager(logDirs: Seq[File],
for ((cleanShutdownFile, dirJobs) <- jobs) {
dirJobs.foreach(_.get)
try {
- cleanShutdownFile.delete()
+ Files.deleteIfExists(cleanShutdownFile.toPath)
Review comment:
`File.delete` doesn't throw an exception and we don't check the result.
So the previous code was very misleading. That's what I was trying to fix. And
to avoid introducing an issue if the file did not exist, I am using
`deleteIfExists`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
