ijuma commented on pull request #8812: URL: https://github.com/apache/kafka/pull/8812#issuecomment-639654363
@rite2nikhil We don't need the flush the segments since we don't increment the recovery point. However, I'm not sure about the `leaderEpochCache`. Offline, @junrao said we didn't have to update it, but I don't fully understand why we do in the case where we delete all the log segments due to the log end offset being smaller than the log start offset. @junrao can you please clarify? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org