mjsax commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r433564798



##########
File path: 
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -906,8 +906,8 @@ public void advanceWallClockTime(final Duration advance) {
         if (record == null) {
             throw new NoSuchElementException("Empty topic: " + topic);
         }
-        final K key = keyDeserializer.deserialize(record.topic(), 
record.key());
-        final V value = valueDeserializer.deserialize(record.topic(), 
record.value());
+        final K key = keyDeserializer.deserialize(record.topic(), 
record.headers(), record.key());

Review comment:
       Not sure if I can follow? `readOutput` is marked as deprecated: 
https://github.com/apache/kafka/blob/trunk/streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java#L797
   
   I can still fix it on the side, but nobody should use it any longer and thus 
the gain seems minimal.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to