ableegoldman commented on a change in pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#discussion_r432231137



##########
File path: 
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java
##########
@@ -582,35 +578,6 @@ public void 
testNoExceptionThrownWhenOnlySubscribedTopicDeleted() {
         assertTrue(assignment.get(consumerId).isEmpty());
     }
 
-    @Test
-    public void testConflictingPreviousAssignments() {

Review comment:
       See comment above: this test was starting from an illegal state. Also, 
it doesn't make sense to place this in the AbstractStickyAssignorTest as the 
cooperative assignor can't have conflicting previous assignments. If a member 
thinks it still owns a partition that now belongs to another member, it will 
have to invoke `onPartitionsLost` before rejoining the group 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to