ableegoldman commented on a change in pull request #8668:
URL: https://github.com/apache/kafka/pull/8668#discussion_r432230560



##########
File path: 
clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java
##########
@@ -169,10 +169,10 @@ public void 
testAssignmentWithConflictingPreviousGenerations() {
         TopicPartition tp5 = new TopicPartition(topic, 5);
 
         List<TopicPartition> c1partitions0 = partitions(tp0, tp1, tp4);
-        List<TopicPartition> c2partitions0 = partitions(tp0, tp2, tp3);
+        List<TopicPartition> c2partitions0 = partitions(tp0, tp1, tp2);

Review comment:
       This test was testing an illegal state to begin with: you should never 
have two consumers in the same generation claim to own the same partition. That 
fact is the entire reason for the generation field to be added to the 
StickyAssignor's subscription userdata to begin with.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to