ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r432183678
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##########
@@ -1468,9 +1456,6 @@ public void
shouldCloseActiveTasksAndIgnoreExceptionsOnUncleanShutdown() {
resetToStrict(changeLogReader);
expect(changeLogReader.completedChangelogs()).andReturn(emptySet());
- // make sure we also remove the changelog partitions from the
changelog reader
- changeLogReader.remove(eq(singletonList(changelog)));
- expectLastCall();
Review comment:
The "unregistration" is now handled by the ProcessorStateManager, which
is mocked in this test. There are new tests in ProcessorStateManagerTest that
verify we unregister the partitions during close/recycle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
