ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r432178832
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java
##########
@@ -79,25 +88,27 @@
private static final String APPID = "restore-test";
- @ClassRule
- public static final EmbeddedKafkaCluster CLUSTER =
- new EmbeddedKafkaCluster(NUM_BROKERS);
+ public final EmbeddedKafkaCluster cluster = new
EmbeddedKafkaCluster(NUM_BROKERS);
Review comment:
I remember now, the main reason for the poor test isolation was
different tests writing various amounts of data to the different topics at
specific offsets. Honestly I'm not sure why this wasn't causing problems before
🤔
Although...I notice that the first test writes 10000 keys to the input topic
starting at offset 0, while the second test to write to the input topic does so
starting at offset 10000. Clearly I should have looked at all the other tests
in the class, counted them up, and then just started writing data at the
highest offset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
