cmccabe commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432159935
##########
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##########
@@ -324,7 +331,7 @@ object TopicCommand extends Logging {
override def deleteTopic(opts: TopicCommandOptions): Unit = {
val topics = getTopics(opts.topic, opts.excludeInternalTopics)
- ensureTopicExists(topics, opts.topic)
+ ensureTopicExists(topics, opts.topic, !opts.ifExists)
Review comment:
Same issue here as above. `Admin#deleteTopics` will fail if the topic
doesn't exist, regardless of line 334.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
