cmccabe commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432159364
##########
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##########
@@ -290,6 +295,8 @@ object TopicCommand extends Logging {
override def describeTopic(opts: TopicCommandOptions): Unit = {
val topics = getTopics(opts.topic, opts.excludeInternalTopics)
+ ensureTopicExists(topics, opts.topic, !opts.ifExists)
Review comment:
Same issue here as above. You can get past this line this way, but you
still fail when actually calling `describeTopics`.
Another issue with this code is that we should not be listing all partition
reassignments. `Admin#listPartitionReassignments` has a variant that takes a
list of partitions. We should use that so that we're not fetching a lot of
information that we don't need. I think this should be an easy fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
