mjsax commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r432123361
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1246,7 +1247,12 @@ public void cleanUp() {
}
log.debug("Current changelog positions: {}", allChangelogPositions);
- final Map<TopicPartition, ListOffsetsResultInfo> allEndOffsets =
fetchEndOffsetsWithoutTimeout(allPartitions, adminClient);
+ final Map<TopicPartition, ListOffsetsResultInfo> allEndOffsets =
+ fetchEndOffsets(
+ allPartitions,
+ adminClient,
+ getAdminDefaultApiTimeoutMs(config)
Review comment:
We should update the JavaDocs that this method may throw a
`TimeoutException` now. What make we wondering if this is a public API change?
Was there any discussion on the original KIP about the behavior of
`allLocalStorePartitionLags` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
