[GitHub] [kafka] mjsax commented on a change in pull request #8738: MINOR: apply default.api.timeout.ms to fetchEndOffsets

[GitBox]

mjsax commented on a change in pull request #8738:
URL: https://github.com/apache/kafka/pull/8738#discussion_r432121258



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/ClientUtilsTest.java
##########
@@ -45,42 +50,42 @@ public void 
fetchEndOffsetsShouldRethrowRuntimeExceptionAsStreamsException() {
         final Admin adminClient = EasyMock.createMock(AdminClient.class);
         
EasyMock.expect(adminClient.listOffsets(EasyMock.anyObject())).andThrow(new 
RuntimeException());
         replay(adminClient);
-        assertThrows(StreamsException.class, () ->  
fetchEndOffsetsWithoutTimeout(emptyList(), adminClient));
+        assertThrows(StreamsException.class, () ->  
fetchEndOffsets(emptyList(), adminClient, 60_000L));

Review comment:
       Should we pass in `MAX_VALUE` to avoid introducing test flakyness?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org