aakashnshah commented on a change in pull request #8720:
URL: https://github.com/apache/kafka/pull/8720#discussion_r430866143
##########
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExampleConnectIntegrationTest.java
##########
@@ -214,6 +218,72 @@ public void testSourceConnector() throws Exception {
connect.deleteConnector(CONNECTOR_NAME);
}
+ @Test
+ public void testErrantRecordReporter() throws Exception {
+ connect.kafka().createTopic(DLQ_TOPIC, 1);
+ // create test topic
+ connect.kafka().createTopic("test-topic", NUM_TOPIC_PARTITIONS);
+
+ // setup up props for the sink connector
+ Map<String, String> props = new HashMap<>();
+ props.put(CONNECTOR_CLASS_CONFIG,
ERRANT_RECORD_SINK_CONNECTOR_CLASS_NAME);
+ props.put(TASKS_MAX_CONFIG, String.valueOf(NUM_TASKS));
+ props.put(TOPICS_CONFIG, "test-topic");
+ props.put(KEY_CONVERTER_CLASS_CONFIG, StringConverter.class.getName());
+ props.put(VALUE_CONVERTER_CLASS_CONFIG,
StringConverter.class.getName());
+ props.put(DLQ_TOPIC_NAME_CONFIG, DLQ_TOPIC);
+
+ // expect all records to be consumed by the connector
+ connectorHandle.expectedRecords(NUM_RECORDS_PRODUCED);
+
+ // expect all records to be consumed by the connector
+ connectorHandle.expectedCommits(NUM_RECORDS_PRODUCED);
+
+ // validate the intended connector configuration, a config that errors
+
connect.assertions().assertExactlyNumErrorsOnConnectorConfigValidation(ERRANT_RECORD_SINK_CONNECTOR_CLASS_NAME,
props, 1,
+ "Validating connector configuration produced an unexpected number
or errors.");
+
+ // add missing configuration to make the config valid
+ props.put("name", CONNECTOR_NAME);
+
+ // validate the intended connector configuration, a valid config
+
connect.assertions().assertExactlyNumErrorsOnConnectorConfigValidation(ERRANT_RECORD_SINK_CONNECTOR_CLASS_NAME,
props, 0,
+ "Validating connector configuration produced an unexpected number
or errors.");
Review comment:
I don't think it hurts to add this step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
