aakashnshah commented on a change in pull request #8720:
URL: https://github.com/apache/kafka/pull/8720#discussion_r430863637
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
##########
@@ -695,6 +705,32 @@ ErrorHandlingMetrics errorHandlingMetrics(ConnectorTaskId
id) {
return reporters;
}
+ private WorkerErrantRecordReporter createWorkerErrantRecordReporter(
+ ConnectorTaskId id,
+ SinkConnectorConfig connConfig,
+ Class<? extends Connector> connectorClass,
+ Converter keyConverter,
+ Converter valueConverter,
+ HeaderConverter headerConverter
+ ) {
+ // check if errant record reporter topic is configured
+ String topic = connConfig.dlqTopicName();
+ if ((topic != null && !topic.isEmpty()) ||
connConfig.enableErrorLog()) {
Review comment:
Nice idea, although unfortunately there were no new configs introduced
in the KIP and I cannot add this to the implementation if it was not apart of
the voted on design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
