[ 
https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110829#comment-17110829
 ] 

Matthias J. Sax commented on KAFKA-4327:
----------------------------------------

Thanks [~jeqo]. The original idea was to move it to `streams` module. Why do 
you want to move it to `tools` module? Or are you referring to move it to 
_package_ {{o.a.k.streams.tools}}?

What parser we are using is an implementation details and does not need to be 
discussed on a KIP. I am fine with your proposal.

However, moving the class to a different module/package and removing zookeeper 
parameter is a breaking change. Thus, we can work on this ticket only for the 
3.0.0 release. It's unclear atm, what the release number after 2.6 will be. 
There was a discussion to maybe do a major release, but as long as the decision 
is no made, I would recommend to hold off. Writing the KIP could be done right 
now, but working on a PR would be too early as we don't know if/when it could 
get merged?

> Move Reset Tool from core to streams
> ------------------------------------
>
>                 Key: KAFKA-4327
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4327
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Jorge Esteban Quilcate Otoya
>            Priority: Blocker
>              Labels: needs-kip
>             Fix For: 3.0.0
>
>
> This is a follow up on https://issues.apache.org/jira/browse/KAFKA-4008
> Currently, Kafka Streams Application Reset Tool is part of {{core}} module 
> due to ZK dependency. After KIP-4 got merged, this dependency can be dropped 
> and the Reset Tool can be moved to {{streams}} module.
> This should also update {{InternalTopicManager#filterExistingTopics}} that 
> revers to ResetTool in an exception message:
> {{"Use 'kafka.tools.StreamsResetter' tool"}}
> -> {{"Use '" + kafka.tools.StreamsResetter.getClass().getName() + "' tool"}}
> Doing this JIRA also requires to update the docs with regard to broker 
> backward compatibility -- not all broker support "topic delete request" and 
> thus, the reset tool will not be backward compatible to all broker versions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to