[ 
https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110609#comment-17110609
 ] 

Jorge Esteban Quilcate Otoya commented on KAFKA-4327:
-----------------------------------------------------

[~mjsax] [~guozhang] I'd like to help closing this one as things have changed 
since it got created:
 * zookeeper dependency has been removed and
 * zookeeper argument deprecated.

This tool carries a dependency to an argument parser that I'm not sure we would 
like to pull into streams module.

I'd like to propose and agree in the following changes before moving forward:
 * move StreamsResetter to `tools` module
 * translate jopt parser (scala) into argparser (java)
 * remove zookeeper parameter

If we agree on this, I can draft a small KIP to get this done.

> Move Reset Tool from core to streams
> ------------------------------------
>
>                 Key: KAFKA-4327
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4327
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Jorge Esteban Quilcate Otoya
>            Priority: Blocker
>              Labels: needs-kip
>             Fix For: 3.0.0
>
>
> This is a follow up on https://issues.apache.org/jira/browse/KAFKA-4008
> Currently, Kafka Streams Application Reset Tool is part of {{core}} module 
> due to ZK dependency. After KIP-4 got merged, this dependency can be dropped 
> and the Reset Tool can be moved to {{streams}} module.
> This should also update {{InternalTopicManager#filterExistingTopics}} that 
> revers to ResetTool in an exception message:
> {{"Use 'kafka.tools.StreamsResetter' tool"}}
> -> {{"Use '" + kafka.tools.StreamsResetter.getClass().getName() + "' tool"}}
> Doing this JIRA also requires to update the docs with regard to broker 
> backward compatibility -- not all broker support "topic delete request" and 
> thus, the reset tool will not be backward compatible to all broker versions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to