mjsax commented on code in PR #22165:
URL: https://github.com/apache/kafka/pull/22165#discussion_r3671439944
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueChangeBuffer.java:
##########
@@ -203,6 +222,10 @@ public void init(final StateStoreContext
stateStoreContext, final StateStore roo
taskId = context.taskId().toString();
streamsMetrics = context.metrics();
+ final Object dslStoreFormat =
stateStoreContext.appConfigs().get(StreamsConfig.DSL_STORE_FORMAT_CONFIG);
Review Comment:
I filed a ticket for it: https://issues.apache.org/jira/browse/KAFKA-20856
-- yes, the idea is to overwrite the config, and yes it would need a KIP. It's
not anything critical; just filed for completeness. Don't think there is high
pressure to pick it up right away.
We can do the same via `Materialized` by passing in a non-header supplier --
even if the DSL configs says headers store (which would pick a
headers-supplier), a custom supplier would take preference effectively
disabling (or enabling) headers and the config does not take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
