aliehsaeedii commented on PR #22165: URL: https://github.com/apache/kafka/pull/22165#issuecomment-5104122941
> I think we are close... -- one main thing is missing tests, but we can add
them as follow up PRs. In particular, it would be good to have a downgrade
system test (maybe also upgrade) to ensure the changes to the changelog topic
don't crash 4.3 or older clients. -- I believe we already have some tests in
general, so maybe it's just a matter of extending them (or if we are lucky,
suppress() might already be covered).
`suppress()` is in the smoke-test topology (`SmokeTestClient#183,195`, both
`untilWindowCloses`), that app is what
`streams_application_upgrade_test.py` drives.
Two gaps, though, so it's a bit more than extending what exists:
1. No system test sets `dsl.store.format` anywhere.
2. The harness is upgrade-only: `to_version` is hardcoded to `DEV_VERSION`
and
`restart_all_nodes_with()` only moves nodes forward. The downgrade
direction has to be built.
I'll file a ticket for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
