ChoMinGi commented on PR #22073: URL: https://github.com/apache/kafka/pull/22073#issuecomment-5002000212
Thanks for the reviews :) Pushed bdc9755 with the extended test — details in the inline reply. On requestRejoin not being quite intended for this — agreed. I did consider restarting only the heartbeat thread. But the client can't know upfront whether the membership is still valid, so that path would need its own fallback to a rejoin when the session has expired, effectively duplicating recovery logic. Reusing the proven rejoin path felt like the right scope for this fix, even though it can cost an unnecessary rebalance when the outage is shorter than the session timeout. If there's interest, I'd be happy to explore a dedicated heartbeat-recovery path in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
