AndrewJSchofield commented on code in PR #22073:
URL: https://github.com/apache/kafka/pull/22073#discussion_r3595030348
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java:
##########
@@ -1288,6 +1288,43 @@ public void testUncaughtExceptionInHeartbeatThread()
throws Exception {
}
}
+ @Test
+ public void testAuthenticationErrorInHeartbeatThreadTriggersRejoin()
throws Exception {
Review Comment:
This test in a way tests that the chosen fix was implemented, namely that
rejoin was requested. What I'd really like to see is a test that does an
authentication failure on the first heartbeat, then the rejoin is requested,
and a subsequent successful heartbeat works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
