ashwinpankaj commented on code in PR #21337: URL: https://github.com/apache/kafka/pull/21337#discussion_r3600751849
########## streams/src/main/java/org/apache/kafka/streams/CloseOptions.java: ########## @@ -14,12 +14,16 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.apache.kafka.streams; +import org.apache.kafka.common.annotation.InterfaceAudience; + import java.time.Duration; import java.util.Objects; import java.util.Optional; [email protected] Review Comment: Thanks @chia7712 - `protected` methods were not published as part of docsJar. But a plugin developer may refer to its signature as part of an overridden method. I agree with the approach you have taken in https://urldefense.com/v3/__https://github.com/apache/kafka/pull/21337*discussion_r3574009798__;Iw!!Ayb5sqE7!uAZbLK-06CCOQ5QeCxqo-Z9DIffXzi46m-whE73S5uGoxizobJT0vxXNqsm3VftloRnanaMOmGQNUun9tHhF$ . Should we also update the docsJar task to include protected methods as well ? This should make things more clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
