omkreddy commented on code in PR #21337:
URL: https://github.com/apache/kafka/pull/21337#discussion_r3466431072
##########
buildSrc/README.md:
##########
@@ -0,0 +1,80 @@
+# Kafka API-checker plugins (buildSrc)
+
+This module builds the KIP-1265 API-checker plugins from a single source tree:
+
+| Plugin / Mojo | ID / artifactId | Audience |
+|---|---|---|
+| `KafkaPublicApiCheckerPlugin` | `org.apache.kafka.public-api-checker`
(Gradle) | Internal — applied to Kafka's own build to validate that
`@InterfaceAudience.Public` types only expose other public types, and that
javadoc inclusion matches the audience annotations. |
+| `KafkaInternalApiCheckerPlugin` | `org.apache.kafka.internal-api-checker`
(Gradle) | External — published for plugin/connector/Streams-app developers to
detect references from their bytecode to non-`@Public` Kafka classes. |
Review Comment:
Can we use the id as `kafka-internal-api-checker-gradle-plugin'` which will
be similar to `kafka-internal-api-checker-maven-plugin`
##########
release/release.py:
##########
@@ -346,6 +346,19 @@ def delete_gitrefs():
confirm_or_fail("Going to build and upload mvn artifacts based on these
settings:\n" + textfiles.read(global_gradle_props) + '\nOK?')
cmd("Building and uploading archives", "./gradlew publish
-PscalaVersion=2.13", cwd=kafka_dir, env=jdk25_env, shell=True)
+# Publishes the KIP-1265 plugin artifacts to the same Nexus staging repo.
buildSrc is a
+# separate Gradle build so the root :publish task does not descend into it.
The four
+# coordinates uploaded here are:
+# org.apache.kafka:kafka-internal-api-checker-gradle-plugin (Gradle
plugin impl jar)
+#
org.apache.kafka.internal-api-checker:org.apache.kafka.internal-api-checker.gradle.plugin
+# (Gradle
plugin marker)
+# org.apache.kafka:kafka-internal-api-checker-maven-plugin (Maven
plugin)
+#
org.apache.kafka.public-api-checker:org.apache.kafka.public-api-checker.gradle.plugin
+#
(Kafka-internal plugin marker)
+# The version is read from gradle.properties — release.py has already bumped
it via
+# `updateVersion` above — so no extra -P flags are needed beyond the publish
credentials,
+# which buildSrc picks up from ~/.gradle/gradle.properties
(mavenUrl/mavenUsername/mavenPassword).
+cmd("Building and uploading archives", "./gradlew :buildSrc:publish
-PscalaVersion=2.13", cwd=kafka_dir, env=jdk25_env, shell=True)
Review Comment:
Can we confirm that this artifact uses the same version as the Kafka
release? It also looks like the `-PscalaVersion=2.13` flag is not required here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
