chia7712 commented on code in PR #22699:
URL: https://github.com/apache/kafka/pull/22699#discussion_r3500415962
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryProvider.java:
##########
@@ -135,6 +136,19 @@ Resource resource() {
return resource;
}
+ /**
+ * The resource attributes as plain labels.
+ *
+ * @return resource attributes keyed by label name, preserving insertion
order.
+ */
+ Map<String, String> resourceLabels() {
Review Comment:
this method could be reused by `updateLabels`
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryProvider.java:
##########
@@ -135,6 +136,19 @@ Resource resource() {
return resource;
}
+ /**
+ * The resource attributes as plain labels.
+ *
+ * @return resource attributes keyed by label name, preserving insertion
order.
+ */
+ Map<String, String> resourceLabels() {
Review Comment:
Should it be `synchronized`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
