chia7712 commented on code in PR #22699:
URL: https://github.com/apache/kafka/pull/22699#discussion_r3498413487
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -725,7 +725,7 @@ private Optional<Builder<?>>
createPushRequest(ClientTelemetrySubscription local
CompressionType compressionType =
ClientTelemetryUtils.preferredCompressionType(localSubscription.acceptedCompressionTypes(),
unsupportedCompressionTypes);
ByteBuffer compressedPayload;
try {
- compressedPayload = ClientTelemetryUtils.compress(payload,
compressionType);
+ compressedPayload =
ClientTelemetryUtils.compress(payload.toByteArray(), compressionType);
Review Comment:
It still makes an unnecessary deep copy. Memory prices have been freaking
high lately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
