Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3482897602
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -171,22 +173,29 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
case Some(epochAndTxnMetadata) => Right(epochAndTxnMetadata)
}
- val result: ApiResult[(Int, TxnTransitMetadata)] =
coordinatorEpochAndMetadata.flatMap {
+ val result: ApiResult[InitProducerIdTransition] =
coordinatorEpochAndMetadata.flatMap {
existingEpochAndMetadata =>
val coordinatorEpoch = existingEpochAndMetadata.coordinatorEpoch
val txnMetadata = existingEpochAndMetadata.transactionMetadata
- txnMetadata.inLock(() =>
- prepareInitProducerIdTransit(transactionalId,
resolvedTxnTimeoutMs, coordinatorEpoch, txnMetadata,
- expectedProducerIdAndEpoch)
- )
+ txnMetadata.inLock(() => {
+ if (keepPreparedTxn && txnMetadata.state ==
TransactionState.ONGOING) {
Review Comment:
Coordinator preserves only existing ONGOING 2PC transactions and returns
the ongoing producer id/epoch for recovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
