Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3482165594
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTransactionTest.java:
##########
@@ -304,6 +357,59 @@ public void testTransactionalShareAckAbortAccept() throws
Exception {
}
}
+ @ClusterTest
+ public void
testTransactionalShareAckAbortWithOutputRecordInSameTransaction() throws
Exception {
+ String groupId = "txn-share-abort-with-output";
+ String inputTopic = "txn-share-abort-with-output-input";
+ String outputTopic = "txn-share-abort-with-output-output";
+ TopicPartition inputTopicPartition = new TopicPartition(inputTopic, 0);
+ TopicPartition outputTopicPartition = new TopicPartition(outputTopic,
0);
+ String outputValue = "derived-first";
+ createTopic(inputTopic);
+ createTopic(outputTopic);
+ alterShareAutoOffsetReset(groupId, "earliest");
+
+ try (Producer<byte[], byte[]> producer = createProducer();
+ Producer<byte[], byte[]> transactionalProducer =
createTransactionalProducer("txn-share-abort-with-output-producer");
+ ShareConsumer<byte[], byte[]> shareConsumer = createShareConsumer(
+ groupId,
+ Map.of(ConsumerConfig.SHARE_ACKNOWLEDGEMENT_MODE_CONFIG,
EXPLICIT));
+ Admin admin = createAdminClient()) {
+
+ producer.send(record(inputTopicPartition, "first")).get();
+ producer.flush();
+
+ shareConsumer.subscribe(Set.of(inputTopic));
+ ConsumerRecords<byte[], byte[]> records =
waitedPoll(shareConsumer, 2500L, 1);
+ ConsumerRecord<byte[], byte[]> record = records.iterator().next();
+ assertEquals(0L, record.offset());
+ assertEquals("first", new String(record.value(),
StandardCharsets.UTF_8));
+
+ ShareGroupMetadata groupMetadata =
shareConsumer.shareGroupMetadata();
+ shareConsumer.acknowledge(record, AcknowledgeType.ACCEPT);
+ ShareAcknowledgements acknowledgements =
shareConsumer.acknowledgementsForTransaction();
+ assertFalse(acknowledgements.isEmpty());
+ TopicIdPartition acknowledgedPartition =
acknowledgements.acknowledgements().keySet().iterator().next();
+ assertEquals(inputTopicPartition,
acknowledgedPartition.topicPartition());
+
+ transactionalProducer.initTransactions();
+ transactionalProducer.partitionsFor(inputTopic);
+ transactionalProducer.partitionsFor(outputTopic);
+ transactionalProducer.beginTransaction();
+ transactionalProducer.send(record(outputTopicPartition,
outputValue)).get();
+
transactionalProducer.sendShareAcknowledgementsToTransaction(acknowledgements,
groupMetadata);
+ transactionalProducer.abortTransaction();
+
+ readCommittedRecords(outputTopicPartition, 0);
+ verifySharePartitionLag(admin, groupId, inputTopicPartition, 1L);
+ ConsumerRecords<byte[], byte[]> redeliveredRecords =
waitedPoll(shareConsumer, 2500L, 1);
+ ConsumerRecord<byte[], byte[]> redeliveredRecord =
redeliveredRecords.iterator().next();
+ assertEquals(0L, redeliveredRecord.offset());
Review Comment:
validation : one Kafka transaction can include both a normal output record
and share acknowledgements.
This is abort case.
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTransactionTest.java:
##########
@@ -304,6 +357,59 @@ public void testTransactionalShareAckAbortAccept() throws
Exception {
}
}
+ @ClusterTest
+ public void
testTransactionalShareAckAbortWithOutputRecordInSameTransaction() throws
Exception {
+ String groupId = "txn-share-abort-with-output";
+ String inputTopic = "txn-share-abort-with-output-input";
+ String outputTopic = "txn-share-abort-with-output-output";
+ TopicPartition inputTopicPartition = new TopicPartition(inputTopic, 0);
+ TopicPartition outputTopicPartition = new TopicPartition(outputTopic,
0);
+ String outputValue = "derived-first";
+ createTopic(inputTopic);
+ createTopic(outputTopic);
+ alterShareAutoOffsetReset(groupId, "earliest");
+
+ try (Producer<byte[], byte[]> producer = createProducer();
+ Producer<byte[], byte[]> transactionalProducer =
createTransactionalProducer("txn-share-abort-with-output-producer");
+ ShareConsumer<byte[], byte[]> shareConsumer = createShareConsumer(
+ groupId,
+ Map.of(ConsumerConfig.SHARE_ACKNOWLEDGEMENT_MODE_CONFIG,
EXPLICIT));
+ Admin admin = createAdminClient()) {
+
+ producer.send(record(inputTopicPartition, "first")).get();
+ producer.flush();
+
+ shareConsumer.subscribe(Set.of(inputTopic));
+ ConsumerRecords<byte[], byte[]> records =
waitedPoll(shareConsumer, 2500L, 1);
+ ConsumerRecord<byte[], byte[]> record = records.iterator().next();
+ assertEquals(0L, record.offset());
+ assertEquals("first", new String(record.value(),
StandardCharsets.UTF_8));
+
+ ShareGroupMetadata groupMetadata =
shareConsumer.shareGroupMetadata();
+ shareConsumer.acknowledge(record, AcknowledgeType.ACCEPT);
+ ShareAcknowledgements acknowledgements =
shareConsumer.acknowledgementsForTransaction();
+ assertFalse(acknowledgements.isEmpty());
+ TopicIdPartition acknowledgedPartition =
acknowledgements.acknowledgements().keySet().iterator().next();
+ assertEquals(inputTopicPartition,
acknowledgedPartition.topicPartition());
+
+ transactionalProducer.initTransactions();
+ transactionalProducer.partitionsFor(inputTopic);
+ transactionalProducer.partitionsFor(outputTopic);
+ transactionalProducer.beginTransaction();
+ transactionalProducer.send(record(outputTopicPartition,
outputValue)).get();
+
transactionalProducer.sendShareAcknowledgementsToTransaction(acknowledgements,
groupMetadata);
+ transactionalProducer.abortTransaction();
+
+ readCommittedRecords(outputTopicPartition, 0);
+ verifySharePartitionLag(admin, groupId, inputTopicPartition, 1L);
+ ConsumerRecords<byte[], byte[]> redeliveredRecords =
waitedPoll(shareConsumer, 2500L, 1);
+ ConsumerRecord<byte[], byte[]> redeliveredRecord =
redeliveredRecords.iterator().next();
+ assertEquals(0L, redeliveredRecord.offset());
Review Comment:
output stays hidden from read_committed, share lag remains 1, and the input
record is redelivered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
