chickenchickenlove commented on code in PR #22199:
URL: https://github.com/apache/kafka/pull/22199#discussion_r3185559311
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberStateListener.java:
##########
@@ -47,4 +47,13 @@ public interface MemberStateListener {
default void onGroupAssignmentUpdated(Set<TopicPartition> partitions) {
}
+
+ /**
+ * Called whenever the consumer group member transitions to a new state.
+ *
+ * @param memberState The new consumer group member state.
+ */
+ default void onConsumerMemberStateChange(MemberState memberState) {
Review Comment:
My original intention was to show that this callback is only needed for the
`ConsumerGroup`. However, since the default method is a no-op, generalizing it
as `onMemberStateUpdated` and letting the call site override it if needed seems
like a better approach.
Thank you! 🙇♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
