lianetm commented on code in PR #22199:
URL: https://github.com/apache/kafka/pull/22199#discussion_r3182224950
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberStateListener.java:
##########
@@ -47,4 +47,13 @@ public interface MemberStateListener {
default void onGroupAssignmentUpdated(Set<TopicPartition> partitions) {
}
+
+ /**
+ * Called whenever the consumer group member transitions to a new state.
+ *
+ * @param memberState The new consumer group member state.
+ */
+ default void onConsumerMemberStateChange(MemberState memberState) {
Review Comment:
should we name it `onMemberStateUpdated` to be consistent with the existing
funcs?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -420,6 +420,8 @@ private StreamsRebalanceListenerInvoker
streamsRebalanceListenerInvoker() {
private final AtomicLong currentThread = new AtomicLong(NO_CURRENT_THREAD);
private final AtomicInteger refCount = new AtomicInteger(0);
+ private volatile boolean memberInReconciliationState = false;
Review Comment:
the reconciliation state means there is a pending reconciliation. Given here
we're at the consumer level (not in the internal state machine impl), would it
be clearer to name this around hasPendingReconciliation or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
