squah-confluent commented on code in PR #21652:
URL: https://github.com/apache/kafka/pull/21652#discussion_r2896858049
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java:
##########
@@ -235,20 +235,23 @@ public static CoordinatorRecord
newConsumerGroupTargetAssignmentTombstoneRecord(
/**
* Creates a ConsumerGroupTargetAssignmentMetadata record.
*
- * @param groupId The consumer group id.
- * @param assignmentEpoch The consumer group epoch.
+ * @param groupId The consumer group id.
+ * @param assignmentEpoch The consumer group epoch.
+ * @param assignmentTimestamp The time at which the target assignment
calculation finished.
* @return The record.
*/
public static CoordinatorRecord
newConsumerGroupTargetAssignmentEpochRecord(
String groupId,
- int assignmentEpoch
+ int assignmentEpoch,
+ long assignmentTimestamp
) {
return CoordinatorRecord.record(
new ConsumerGroupTargetAssignmentMetadataKey()
.setGroupId(groupId),
new ApiMessageAndVersion(
new ConsumerGroupTargetAssignmentMetadataValue()
- .setAssignmentEpoch(assignmentEpoch),
+ .setAssignmentEpoch(assignmentEpoch)
+ .setAssignmentTimestamp(assignmentTimestamp),
Review Comment:
I've renamed them to
`new{Consumer,Share,Streams}GroupTargetAssignmentMetadataRecord`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
