squah-confluent commented on code in PR #21652:
URL: https://github.com/apache/kafka/pull/21652#discussion_r2895871456
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java:
##########
@@ -457,7 +457,7 @@ SyncGroupRequestData build() {
}
public static class Builder {
- private MockTime time = new MockTime(0, 0, 0);
+ private MockTime time = new MockTime(0, 1000, 1000);
Review Comment:
The PR relies on existing tests to cover classic to consumer upgrades and
assignments. Most of the tests which capture `targetAssignmentTimestamp` test
assignments in some way. I'd rather not set the time manually for all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
