mjsax commented on code in PR #21599:
URL: https://github.com/apache/kafka/pull/21599#discussion_r2887515476
##########
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##########
@@ -58,13 +62,46 @@ public DslWindowParams(
final boolean isTimestamped
) {
this.isTimestamped = isTimestamped;
- Objects.requireNonNull(name);
- this.name = name;
+ this.name = Objects.requireNonNull(name);
this.retentionPeriod = retentionPeriod;
this.windowSize = windowSize;
this.retainDuplicates = retainDuplicates;
this.emitStrategy = emitStrategy;
this.isSlidingWindow = isSlidingWindow;
+ // If isTimestamped is false and the user is still calling the old
deprecated constructor, we should assume they mean plain.
Review Comment:
This makes sense to me -- the old constructor does not allow set "headers".
-- What are you not sure about this Alieh? Maybe I am missing someting?
Also: I don't think use would ever _create_ and object of this class to
begin with? -- Maybe it should have been an interface...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
