aliehsaeedii commented on code in PR #21599:
URL: https://github.com/apache/kafka/pull/21599#discussion_r2874540718
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##########
@@ -89,7 +90,7 @@ public StoreBuilder<?> builder() {
true,
EmitStrategy.onWindowUpdate(),
false,
- false
+ DslStoreFormat.PLAIN
Review Comment:
What if the user sets it to `headers`?
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/WindowStoreMaterializer.java:
##########
@@ -64,15 +65,22 @@ public StoreBuilder<?> builder() {
false,
emitStrategy,
false,
- true
+ storeFormat
))
: (WindowBytesStoreSupplier) materialized.storeSupplier();
- final StoreBuilder<TimestampedWindowStore<K, V>> builder =
Stores.timestampedWindowStoreBuilder(
+ final StoreBuilder<?> builder;
+ if (storeFormat == DslStoreFormat.HEADERS) {
+ builder = Stores.timestampedWindowStoreWithHeadersBuilder(
supplier,
materialized.keySerde(),
- materialized.valueSerde()
- );
+ materialized.valueSerde());
+ } else {
Review Comment:
I assume we will always have `timestampedWindowStoreWithHeadersBuilder`
without considering the store format value. Please chack
https://github.com/aliehsaeedii/kafka/blob/1569454913696855bcabd4868aa8fddad0b9d283/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java#L59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
