JimmyWang6 commented on code in PR #20973:
URL: https://github.com/apache/kafka/pull/20973#discussion_r2565331321
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareAcquireMode.java:
##########
@@ -65,7 +65,7 @@ public static ShareAcquireMode forId(byte id) {
@Override
public String toString() {
- return "ShareAcquireMode(" + name + " (" + id + "))";
+ return name;
Review Comment:
This originates from the comment at
https://github.com/apache/kafka/pull/20246#discussion_r2494584030. I find the
valid values here seem a bit odd:
<img width="1090" height="521" alt="image"
src="https://github.com/user-attachments/assets/6685fcba-e265-4e65-8b98-792c7c137afa";
/>
They appear to come directly from the `Validator`'s toString() output, so it
would be better to make the enum consistent and also fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
