chirag-wadhwa5 commented on code in PR #20973:
URL: https://github.com/apache/kafka/pull/20973#discussion_r2564648496
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1827,13 +1827,13 @@ private List<AcquiredRecords> createBatches(
sharePartitionMetrics);
int delayMs =
recordLockDurationMsOrDefault(groupConfigManager, groupId,
defaultRecordLockDurationMs);
long lastOffset = acquiredRecords.firstOffset() +
maxFetchRecords - 1;
+ sharePartitionMetrics.recordInFlightBatchMessageCount(
Review Comment:
nit: can we please update the metric after the batch has been added to the
cached state ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
