jiafu1115 commented on PR #20203: URL: https://github.com/apache/kafka/pull/20203#issuecomment-3476415923
> > > LGTM. Just need to update the KIP afterward. > > > > > > sure. thanks for your view. already done yesterday and send mail to comminuty. > > I see. Nit: BrokerReadyCallback is not actually a public interface that will be exposed to users. It may be better to move it from the `Public Interface` section to `Proposed Changes`. Furthermore, it is good to elaborate on the behavior change for TopicBasedRemoteLogMetadataManager in the `Public Interface` section. @Yunyung make sense. thanks for your reminder. KIP content updated now: 1. Move the interface description to the correct section and add a note explaining the reason. 2. Add Javadoc comments to the implementation of the interface methods to provide more information. BTW: I won’t send an email about this organizational change, since the key updates have already been sent out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
